Skip to content

[Fixes #319] Add Vue.extend support #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2018
Merged

[Fixes #319] Add Vue.extend support #322

merged 1 commit into from
Jan 28, 2018

Conversation

michalsnik
Copy link
Member

#319

This PR adds support for detecting Vue.extend as components, also it adds missing information about Vue.mixin in readme.

Unfortunately I think it should be merged once we're ready to release new major version, as it might potentially break some CI builds.

@michalsnik michalsnik requested a review from mysticatea January 2, 2018 23:39
@blake-newman
Copy link
Member

Not sure this is an issue, i have seen in places where export default Vue.extend is used. Will this capture this aswell. I think this is used with TS based projects, may not be so much of an issue now.

@michalsnik
Copy link
Member Author

It's not an issue, should work fine @blake-newman :) We look for CallExpressions so export part is entirely omitted in this check. We only check for export default in .vue and .jsx files to determine it as component.

@michalsnik michalsnik requested a review from chrisvfritz January 6, 2018 23:15
@michalsnik michalsnik self-assigned this Jan 6, 2018
chrisvfritz
chrisvfritz approved these changes Jan 22, 2018
View reviewed changes
Copy link
Contributor

@chrisvfritz chrisvfritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me in theory. 🙂 I didn't test whether it works and am not expert enough to know whether this is an ideal implementation.

@michalsnik michalsnik merged commit 98dbf8a into master Jan 28, 2018
@michalsnik michalsnik deleted the add-vue-extend-trigger branch January 28, 2018 22:55
michalsnik added a commit that referenced this pull request Feb 24, 2018
@michalsnik
Update: Add Vue.extend support and missing info about Vue.mixin in Re…
d3e7d4c 
…adme (#322)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mysticatea mysticatea mysticatea approved these changes

@chrisvfritz chrisvfritz chrisvfritz approved these changes

Assignees

@michalsnik michalsnik

Labels
semver-major
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michalsnik @blake-newman @mysticatea @chrisvfritz